-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DescribeTopics and DescribeCluster support for admin client API #721
base: master
Are you sure you want to change the base?
Add DescribeTopics and DescribeCluster support for admin client API #721
Conversation
let high_bits = unsafe { rdsys::rd_kafka_Uuid_most_significant_bits(topic_id) } as u64; | ||
let low_bits = unsafe { rdsys::rd_kafka_Uuid_least_significant_bits(topic_id) } as u64; | ||
Uuid::from_u64_pair(high_bits, low_bits) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really worth adding a dependency to the uuid
crate when Uuid
is only used here? We might as well remove the dependency and only return a (high_bits, low_bits)
tuple.
I added DescribeCluster support as well. DescribeConsumerGroups should also be relatively easier to implement since the some of the types it returns ( |
I'm satisfied with the PR myself but there are a few points in my mind:
|
@davidblewett @benesch Any opportunities to review and possibly merge within next week? |
Closes #614
Adding DescribeTopics
nowandalso potentiallyDescribeCluster in this PR as per #614I'll write the docs and tests, and then mark as ready for review