Use CStr::from_bytes_until_nul to read rdkafka config #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
353812f has not been released on crates.io as far as I can tell. => No need to add the bugfix to the changelog. |
|
Important note: |
We want to use `CStr::from_bytes_until_nul` for reading values from rdkafka.
Commit 353812f replaced the more finicky `CStr::from_bytes_with_nul` with `String::from_utf8_lossy`. That eliminated a panic but the returned Rust string now contained NUL bytes. This might have accidentally worked in FFI APIs that take C strings, but it fails when such a string is passed to a Rust API, such as integer parsing in `stream_consumer.rs:217`. The newer `CStr::from_bytes_until_nul` function 1. does not panic 2. ends the string at the first NUL byte It does return an error when there is no NUL byte in the input slice. While it would be possible to fall back to `String::from_utf8_lossy` in that case, I'm not sure that would be a good idea. If we are in that situation, librdkafka clearly has messed something up completely. The contents of the buffer are then more likely complete garbage.
chklauser
force-pushed
the
fix-cstr-conversion-from-config
branch
from
cb71e7c to
fc8d46b
Compare
|
Indeed! I've included a bump to version 1.69 in the PR (as a separate commit). Rust 1.69 was released 20 April, 2023. Seems a reasonable upgrade to me, but I don't really have a stake in that decision (we are using latest stable). |
|
It seems there are a total of three PRs for this error now :( |
This was referenced Jun 16, 2024
|
There is one more PR with the fix but contains also other changes: #647 |
|
Closed in favor of #688 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 353812f replaced the more finicky
CStr::from_bytes_with_nulwithString::from_utf8_lossy. This causes tests to fail, both for me locally and in CI.That commit eliminated a panic but now the returned Rust string (from
NativeClientConfig.get) contains NUL bytes. This might have accidentally worked in FFI APIs that take C strings, but it fails when such a string is passed to a Rust API, such as integer parsing instream_consumer.rs:217.The newer
CStr::from_bytes_until_nulfunctionIt does return an error when there is no NUL byte in the input slice.
While it would be possible to fall back to
String::from_utf8_lossyin that case, I'm not sure that would be a good idea. If we are in that situation, librdkafka clearly has messed something up completely. The contents of the buffer are then more likely complete garbage.