Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gemspec to match Gemfile #1173

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Update gemspec to match Gemfile #1173

merged 1 commit into from
Oct 12, 2023

Conversation

steveyken
Copy link
Member

This brings parity when fat_free_crm is loaded as an engine, via a gem.

Fixes following bundler error when including fat_free_crm as a gem

Fetching https://github.com/fatfreecrm/acts_as_commentable.git
Fetching https://github.com/CloCkWeRX/responds_to_parent.git
Fetching https://github.com/fatfreecrm/fat_free_crm.git
Fetching gem metadata from http://rubygems.org/...........
Resolving dependencies...
Could not find compatible versions

Because acts_as_commentable >= 6.0.0, < 6.1.A could not be found in https://github.com/fatfreecrm/acts_as_commentable.git (at rails-61@e695ef5)
  and every version of fat_free_crm depends on acts_as_commentable ~> 6.0.0,
  fat_free_crm cannot be used.
So, because Gemfile depends on fat_free_crm >= 0,
  version solving has failed.

@steveyken steveyken requested a review from CloCkWeRX October 11, 2023 01:04
@CloCkWeRX CloCkWeRX merged commit b8f065b into master Oct 12, 2023
8 checks passed
@CloCkWeRX CloCkWeRX deleted the gemspec-fixes branch October 12, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants