Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize skunk.gemspec: Streamlined gem specification and cleaned metadata and file handling. #118

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optimize skunk.gemspec: Streamlined gem specification and cleaned metadata and file handling. #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 13 additions & 20 deletions skunk.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,33 +14,26 @@ Gem::Specification.new do |spec|
spec.description = "Knows how to calculate the SkunkScore for a set of Ruby modules"
spec.homepage = "https://github.com/fastruby/skunk"

spec.required_ruby_version = [">= 2.4.0"]

# Prevent pushing this gem to RubyGems.org. To allow pushes either set the 'allowed_push_host'
# to allow pushing to a single host or delete this section to allow pushing to any host.
if spec.respond_to?(:metadata)
spec.metadata["allowed_push_host"] = "https://www.rubygems.org"

spec.metadata["homepage_uri"] = spec.homepage
spec.metadata["source_code_uri"] = "https://github.com/fastruby/skunk"
spec.metadata["changelog_uri"] = "https://github.com/fastruby/skunk/blob/main/CHANGELOG.md"
else
raise "RubyGems 2.0 or newer is required to protect against " \
"public gem pushes."
end

# Specify which files should be added to the gem when it is released.
# The `git ls-files -z` loads the files in the RubyGem that have been added into git.
spec.files = Dir.chdir(File.expand_path(__dir__)) do
`git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(bin|test|spec|features)/}) }
end
spec.required_ruby_version = ">= 2.4.0"

# Prevent pushing this gem to RubyGems.org unless specified
spec.metadata["allowed_push_host"] = "https://www.rubygems.org" if spec.respond_to?(:metadata)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @infyomer, Thanks for the contribution, however, I'm not sure this is the right change. If you keep the if for this line, why didn't you add it for the next 3 metadata lines?


spec.metadata["homepage_uri"] = spec.homepage
spec.metadata["source_code_uri"] = "https://github.com/fastruby/skunk"
spec.metadata["changelog_uri"] = "https://github.com/fastruby/skunk/blob/main/CHANGELOG.md"

# Specify which files should be added to the gem
spec.files = Dir.chdir(__dir__) { `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(bin|test|spec|features)/}) } }
spec.bindir = "exe"
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ["lib"]

# Dependencies
spec.add_dependency "rubycritic", ">= 4.5.2", "< 5.0"
spec.add_dependency "terminal-table", "~> 3.0"

# Development dependencies
spec.add_development_dependency "codecov", "~> 0.1.16"
spec.add_development_dependency "debug"
spec.add_development_dependency "minitest", "< 6"
Expand Down