Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multi client examples #147

Merged
merged 6 commits into from
Oct 3, 2023
Merged

add multi client examples #147

merged 6 commits into from
Oct 3, 2023

Conversation

edgarriba
Copy link
Member

@edgarriba edgarriba commented Oct 2, 2023

Add a couple of examples showing how to use multiple clients:

  • Simple multi client subscriber
  • Camera and GPS with a non-bullet proof sync to geo tag images

Goes with farm-ng/amiga-dev-kit#200

@edgarriba edgarriba marked this pull request as ready for review October 2, 2023 14:04
@edgarriba edgarriba changed the title [wip] add a multi client examples add multi client examples Oct 2, 2023
Copy link
Collaborator

@Hackerman342 Hackerman342 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 👌

py/examples/multi_client_geoimage/main.py Outdated Show resolved Hide resolved
py/examples/multi_client_geoimage/main.py Outdated Show resolved Hide resolved
py/examples/multi_client_subscriber/main.py Show resolved Hide resolved
py/examples/multi_client_geoimage/config.json Outdated Show resolved Hide resolved
py/examples/multi_client_geoimage/main.py Outdated Show resolved Hide resolved
Copy link
Contributor

@guilhermedemouraa guilhermedemouraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it worked just fine!
For the client_geoimage example, I was never able to get synchronized data. Perhaps it was because I was running it on my local PC. Recommend loosening the constraint for the stamp_diff.

On another note, for the multi_client_subscriber example, I think it would be nice to print the messages received instead of printing that a message was received (or maybe printing both).

@edgarriba
Copy link
Member Author

On another note, for the multi_client_subscriber example, I think it would be nice to print the messages received instead of printing that a message was received (or maybe printing both).

the terminal gets too cluttered

@edgarriba edgarriba merged commit b0ac80c into main-v2 Oct 3, 2023
2 checks passed
@edgarriba edgarriba deleted the multi-client-examples branch October 3, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants