Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: typo fix Update publish-image.sh #2453

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

defitricks
Copy link
Contributor

@defitricks defitricks commented Dec 22, 2024

Why is this change needed?

The word "permissions" is used in plural form. However, it would be more accurate to use "permission" in singular, as it typically refers to general access rather than multiple specific rights in this context.

Merge Checklist


PR-Codex overview

This PR focuses on correcting the grammatical error in the comments of the scripts/publish-image.sh file regarding permissions for Docker login.

Detailed summary

  • Changed "necessary permissions" to "necessary permission" in the comment about Docker login.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Dec 22, 2024

⚠️ No Changeset found

Latest commit: 3eefde7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2024 5:02pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant