Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple typos of different importance #2452

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/hubble/src/network/sync/syncEngine.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1652,7 +1652,7 @@ class SyncEngine extends TypedEmitter<SyncEvents> {
// If the hashes match, we do not need to do any work
if (ourNode && ourNode.hash === theirNode.hash) return;

// If there are no messages to fetch, don't enque the work item
// If there are no messages to fetch, don't enqueue the work item
if (theirNode.numMessages === 0) return;

// Don't let the queue grow too large
Expand Down Expand Up @@ -1696,7 +1696,7 @@ class SyncEngine extends TypedEmitter<SyncEvents> {
// Replace the work queue with only the items that are not completed
runningWorkItems = newRunningWorkItems;

// If there is an oppurtunity to do more work, we will do it
// If there is an opportunity to do more work, we will do it
if (this.curSync.executingWorkCount < syncParallelism) {
const n = Math.max(0, syncParallelism - this.curSync.executingWorkCount);

Expand Down Expand Up @@ -1766,7 +1766,7 @@ class SyncEngine extends TypedEmitter<SyncEvents> {
(c) => c.peerId !== this.curSync.peerId,
);

// If none left, then interrupt the sync
// If none are left, then interrupt the sync
if (this.curSync.secondaryRpcClients.length === 0) {
this.curSync.interruptSync = true;
log.warn("Perform Sync: PeerError: No more secondary peers, interrupting sync");
Expand All @@ -1789,7 +1789,7 @@ class SyncEngine extends TypedEmitter<SyncEvents> {
await this.getMessagesFromOtherNode(workItem, theirNode.numMessages);
}

// Recurse into the children to to schedule the next set of work. Note that we didn't after the
// Recurse into the children to schedule the next set of work. Note that we didn't after the
// `getMessagesFromOtherNode` above. This is because even after we get messages from the other node,
// there still might be left over messages at this node (if, for eg., there are > 10k messages, and the
// other node only sent 1k messages).
Expand Down
2 changes: 1 addition & 1 deletion apps/hubble/src/network/utils/networkConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ export function applyNetworkConfig(

if (semver.valid(minAppVersion)) {
if (semver.lt(APP_VERSION, minAppVersion)) {
const errMsg = "Hubble version is too old too start. Please update your node.";
const errMsg = "Hubble version is too old to start. Please update your node.";
log.fatal({ minAppVersion, ourVersion: APP_VERSION }, errMsg);
return {
allowedPeerIds,
Expand Down
2 changes: 1 addition & 1 deletion apps/hubble/src/profile/gossipProfileWorker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ class GossipTestNode {
}

async start() {
// Override the peer score threholds. When running benchmark tests, we want to accept all messages
// Override the peer score thresholds. When running benchmark tests, we want to accept all messages
// and not unnecessarily graylist peers (which libp2p does since all the connections appear to come
// from the same IP)
await this.gossipNode.start([], {
Expand Down
2 changes: 1 addition & 1 deletion apps/hubble/src/storage/db/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export enum RootPrefix {
// Deprecated, DO NOT USE
// GossipMetrics = 18,

/* Used to index user submited username proofs */
/* Used to index user submitted username proofs */
UserNameProofByName = 19,

// Deprecated
Expand Down