Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug in PerformBaseRelocation #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

H4ckF0rFun
Copy link

Bug

The end cannot be determined based on whether the Virtual Address of the next IMAGE_BASE_RELOCATION is 0 or not. In fact, it is possible that the next IMAGE_BASE_RELOCATION exceeds the size of the entire directory.
The data it contains is completely uncertain.

Instead, use directory size to determine if you've reached the end.

Sample:

image

By the time you get to the end, you have exceeded the size of the entire relocation table, and the memory after that is invalid, which will cause an exception if you use the Virtual Address

image

image

Why does this approach work most of the time?

The secetion in which the relocation table is located is page aligned, and in most cases there is memory for alignment behind the relocation table, which is filled with 0x00.

image

@H4ckF0rFun
Copy link
Author

And in fact, it is not necessary to determine whether the end is reached based on whether the virtual address of the next block is 0 or not. directory_size and the size of each block are enough to tell if the end is reached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant