Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fixed bump-libs workflow syntax. #3369

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix(ci): fixed bump-libs workflow syntax. #3369

merged 1 commit into from
Oct 7, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Oct 7, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area CI

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 7, 2024

/milestone 0.40.0

@poiana poiana added this to the 0.40.0 milestone Oct 7, 2024
@poiana poiana requested review from Kaizhe and leogr October 7, 2024 09:45
@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 7, 2024

@FedeDP FedeDP changed the title wip: fix(ci): fixed bump-libs workflow syntax. fix(ci): fixed bump-libs workflow syntax. Oct 7, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 7, 2024

/hold
it does not actually: https://github.com/falcosecurity/falco/pull/3370/files

leogr
leogr previously approved these changes Oct 7, 2024
@poiana poiana added the lgtm label Oct 7, 2024
@FedeDP FedeDP force-pushed the fix/bump-libs branch 2 times, most recently from af91b38 to 08f7544 Compare October 7, 2024 11:32
@poiana poiana added size/S and removed size/XS labels Oct 7, 2024
@FedeDP FedeDP force-pushed the fix/bump-libs branch 2 times, most recently from f1d4c0b to 93f1c2f Compare October 7, 2024 11:38
@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 7, 2024

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Oct 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 7b2feb1 into master Oct 7, 2024
35 checks passed
@poiana poiana deleted the fix/bump-libs branch October 7, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants