Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker/no-driver/Dockerfile.no-falcoctl-distroless): Provide distroless falco image without falcoctl #3176

Closed

Conversation

killerkenobi
Copy link

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:
This PR introduces a new Docker image that builds the Falco application without falcoctl present in said image. People could build Falco using this Docker image if they are operating Falco in a sensitive environment or just don't want/need falcoctl. This proposed Dockerfile can also reduce the attack surface introduced by falcoctl in the Falco image.

Which issue(s) this PR fixes:

Related to points made in #3165

Special notes for your reviewer:
After reading through #3165 I noticed that there is a proposal to depreciate the Falco distroless image. I figured I would open this PR anyway to help with the dev work / show that there is interest in having a Falco image that does not contain falcoctl.

Does this PR introduce a user-facing change?:

feat(docker/no-driver/Dockerfile.no-falcoctl-distroless): Users now have the option to build the Falco Docker image without installing falcoctl.

@poiana
Copy link
Contributor

poiana commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: killerkenobi
Once this PR has been reviewed and has the lgtm label, please assign fededp for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from Kaizhe and leogr April 23, 2024 01:38
@poiana
Copy link
Contributor

poiana commented Apr 23, 2024

Welcome @killerkenobi! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana poiana added the size/M label Apr 23, 2024
@killerkenobi killerkenobi force-pushed the no-falcoctl-distroless branch from b1cd657 to b84761f Compare April 23, 2024 01:48
@FedeDP
Copy link
Contributor

FedeDP commented Apr 23, 2024

Hi! Thanks for this PR!
Yes, #3165 wants to deprecate old distroless image BUT because the falco main image would become a distroless one; see the first table:

falcosecurity/falco x.y.z (latest) Distroless image without driver building toolchain support, based on the latest released tar.gz of Falco. No tools or falcoctl not included.

I don't think we will be able to tackle #3165 for the 0.38.0 release, but we will for sure for the 0.39.0.

cc @leogr

@FedeDP
Copy link
Contributor

FedeDP commented May 16, 2024

/milestone TBD

@poiana poiana added this to the TBD milestone May 16, 2024
@poiana
Copy link
Contributor

poiana commented Aug 14, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@FedeDP
Copy link
Contributor

FedeDP commented Aug 20, 2024

/remove-lifecycle stale

@leogr
Copy link
Member

leogr commented Nov 6, 2024

Superseded by #3273

Still, I would like to use the multi-stage build like in this PR. So we will likely reuse this code anyway, and ofc credit @killerkenobi for this contribution. Thank you! 🙏

/close

@poiana poiana closed this Nov 6, 2024
@poiana
Copy link
Contributor

poiana commented Nov 6, 2024

@leogr: Closed this PR.

In response to this:

Superseded by #3273

Still, I would like to use the multi-stage build like in this PR. So we will likely reuse this code anyway, and ofc credit @killerkenobi for this contribution. Thank you! 🙏

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants