-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker/no-driver/Dockerfile.no-falcoctl-distroless): Provide distroless falco image without falcoctl #3176
feat(docker/no-driver/Dockerfile.no-falcoctl-distroless): Provide distroless falco image without falcoctl #3176
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: killerkenobi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @killerkenobi! It looks like this is your first PR to falcosecurity/falco 🎉 |
b1cd657
to
b84761f
Compare
Hi! Thanks for this PR!
I don't think we will be able to tackle #3165 for the 0.38.0 release, but we will for sure for the 0.39.0. cc @leogr |
Signed-off-by: Anthony <[email protected]>
Signed-off-by: Anthony <[email protected]>
Signed-off-by: Anthony <[email protected]>
b84761f
to
82961e3
Compare
/milestone TBD |
Issues go stale after 90d of inactivity. Mark the issue as fresh with Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with Provide feedback via https://github.com/falcosecurity/community. /lifecycle stale |
/remove-lifecycle stale |
Superseded by #3273 Still, I would like to use the multi-stage build like in this PR. So we will likely reuse this code anyway, and ofc credit @killerkenobi for this contribution. Thank you! 🙏 /close |
@leogr: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
This PR introduces a new Docker image that builds the Falco application without falcoctl present in said image. People could build Falco using this Docker image if they are operating Falco in a sensitive environment or just don't want/need falcoctl. This proposed Dockerfile can also reduce the attack surface introduced by falcoctl in the Falco image.
Which issue(s) this PR fixes:
Related to points made in #3165
Special notes for your reviewer:
After reading through #3165 I noticed that there is a proposal to depreciate the Falco distroless image. I figured I would open this PR anyway to help with the dev work / show that there is interest in having a Falco image that does not contain falcoctl.
Does this PR introduce a user-facing change?: