fix(docker,scripts): do not load falcoctl driver loader when installing Falco deb package in docker images #3166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng Falco deb package in docker image. Signed-off-by: Federico Di Pierro <[email protected]>
|
/milestone 0.38.0 |
FedeDP
commented
Apr 15, 2024
| @@ -92,7 +92,7 @@ RUN rm -rf /usr/bin/clang \ | |||
| RUN curl -s https://falco.org/repo/falcosecurity-packages.asc | apt-key add - \ | |||
| && echo "deb https://download.falco.org/packages/${VERSION_BUCKET} stable main" | tee -a /etc/apt/sources.list.d/falcosecurity.list \ | |||
| && apt-get update -y \ | |||
| && if [ "$FALCO_VERSION" = "latest" ]; then apt-get install -y --no-install-recommends falco; else apt-get install -y --no-install-recommends falco=${FALCO_VERSION}; fi \ | |||
| && if [ "$FALCO_VERSION" = "latest" ]; then FALCO_DRIVER_CHOICE=none apt-get install -y --no-install-recommends falco; else FALCO_DRIVER_CHOICE=none apt-get install -y --no-install-recommends falco=${FALCO_VERSION}; fi \ | |||
There was a problem hiding this comment.
Avoid running driver loader at this stage
FedeDP
commented
Apr 15, 2024
| @@ -44,7 +44,7 @@ RUN apt-get update \ | |||
| RUN curl -s https://falco.org/repo/falcosecurity-packages.asc | apt-key add - \ | |||
| && echo "deb https://download.falco.org/packages/${VERSION_BUCKET} stable main" | tee -a /etc/apt/sources.list.d/falcosecurity.list \ | |||
| && apt-get update -y \ | |||
| && if [ "$FALCO_VERSION" = "latest" ]; then apt-get install -y --no-install-recommends falco; else apt-get install -y --no-install-recommends falco=${FALCO_VERSION}; fi \ | |||
| && if [ "$FALCO_VERSION" = "latest" ]; then FALCO_DRIVER_CHOICE=none apt-get install -y --no-install-recommends falco; else FALCO_DRIVER_CHOICE=none apt-get install -y --no-install-recommends falco=${FALCO_VERSION}; fi \ | |||
There was a problem hiding this comment.
Avoid running driver loader at this stage
FedeDP
commented
Apr 15, 2024
| @@ -80,7 +80,7 @@ if [ "$1" = "configure" ]; then | |||
| ;; | |||
| esac | |||
| if [ -n "$chosen_driver" ]; then | |||
| echo "[POST-INSTALL] Configure falcoctl driver type:" | |||
| echo "[POST-INSTALL] Configure falcoctl '$chosen_driver' driver type:" | |||
FedeDP
commented
Apr 15, 2024
| @@ -79,6 +79,7 @@ if [ $1 -ge 1 ]; then | |||
| ;; | |||
| esac | |||
| if [ -n "$chosen_driver" ]; then | |||
| echo "[POST-INSTALL] Configure falcoctl '$chosen_driver' driver type:" | |||
There was a problem hiding this comment.
Debug print (same as deb package!)
|
/cc @leogr @Andreagit97 |
leogr
approved these changes
Apr 15, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Fixup after #3154
See master CI: https://github.com/falcosecurity/falco/actions/runs/8689791911/job/23829879902
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: