Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: enable compilation on win32 and macOS #2889

Merged
merged 26 commits into from
Nov 13, 2023

Conversation

therealbobo
Copy link
Contributor

@therealbobo therealbobo commented Oct 25, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:

This enables falco to be build on Windows and MacOS.

Which issue(s) this PR fixes:

#2672

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

new(build): enable compilation on win32 and macOS.

@poiana poiana requested review from Kaizhe and LucaGuerra October 25, 2023 12:08
@therealbobo therealbobo force-pushed the ci/other-platforms branch 6 times, most recently from ec71bd4 to 590b82f Compare October 25, 2023 19:39
@poiana poiana added size/XL and removed size/L labels Oct 25, 2023
@therealbobo therealbobo force-pushed the ci/other-platforms branch 6 times, most recently from 4580d2d to 7f7ae6b Compare October 25, 2023 22:03
@therealbobo therealbobo changed the title wip: build: enable compilation on win32 and macOS build: enable compilation on win32 and macOS Oct 26, 2023
@therealbobo therealbobo marked this pull request as ready for review October 26, 2023 16:10
@poiana poiana requested a review from jasondellaluce October 26, 2023 16:10
@therealbobo therealbobo force-pushed the ci/other-platforms branch 2 times, most recently from 357e975 to 9f079b6 Compare October 27, 2023 10:39
@therealbobo therealbobo force-pushed the ci/other-platforms branch 2 times, most recently from c156492 to 8c6a3d5 Compare November 6, 2023 11:23
@therealbobo therealbobo closed this Nov 6, 2023
@therealbobo therealbobo reopened this Nov 6, 2023
@therealbobo therealbobo force-pushed the ci/other-platforms branch 2 times, most recently from 4d2d6e5 to 639ef02 Compare November 6, 2023 16:13
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Nov 8, 2023

LGTM label has been added.

Git tree hash: 2f563f19d6894050057e4d8d656c8ab72f91a483

@poiana poiana added the approved label Nov 8, 2023
@FedeDP
Copy link
Contributor

FedeDP commented Nov 8, 2023

/milestone 0.37.0

@poiana poiana added this to the 0.37.0 milestone Nov 8, 2023
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, therealbobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 92b42c9 into falcosecurity:master Nov 13, 2023
16 of 17 checks passed
@FedeDP
Copy link
Contributor

FedeDP commented Nov 13, 2023

Updated the release note label to allow the PR to get merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants