Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(cmake): bump libs and driver to 5b4e28d4 #2879

Closed
wants to merge 3 commits into from

Conversation

jasondellaluce
Copy link
Contributor

What type of PR is this?

/kind cleanup

/kind release

Any specific area of the project related to this PR?

/area engine

/area tests

What this PR does / why we need it:

This adjusts Falco for compiling with the newest libs and and drivers and bumps their dependency.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update(cmake): bump libs and driver to 5b4e28d4 

@FedeDP
Copy link
Contributor

FedeDP commented Oct 18, 2023

/milestone 0.37.0

@poiana poiana added this to the 0.37.0 milestone Oct 18, 2023
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Oct 18, 2023

LGTM label has been added.

Git tree hash: abe6b3b317fe42c0bc24cccc750f32d1634ac02d

@jasondellaluce
Copy link
Contributor Author

Seems like the we have issues with the MUSL static build. This seems to be the offending PR -- falcosecurity/libs#1394

Any ideas @LucaGuerra, @jcpittman144?

Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Oct 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, incertum, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,incertum,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Andreagit97
Copy link
Member

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants