Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(doc) Add Wireshark / Logray as adopters #2867

Merged
merged 1 commit into from
Oct 12, 2023
Merged

update(doc) Add Wireshark / Logray as adopters #2867

merged 1 commit into from
Oct 12, 2023

Conversation

geraldcombs
Copy link
Contributor

@geraldcombs geraldcombs commented Oct 11, 2023 •
edited by FedeDP
Loading

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update(docs): add Wireshark/Logray as adopter

@poiana
Copy link
Contributor

poiana commented Oct 11, 2023

Welcome @geraldcombs! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana poiana requested review from Kaizhe and leogr October 11, 2023 18:45
@poiana poiana added the size/XS label Oct 11, 2023
FedeDP
FedeDP approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Oct 12, 2023
@FedeDP
Copy link
Contributor

FedeDP commented Oct 12, 2023

/milestone 0.37.0

@poiana
Copy link
Contributor

poiana commented Oct 12, 2023

LGTM label has been added.

Git tree hash: ec97322886dce48d5414d1b182e08be394876c00

@poiana poiana added this to the 0.37.0 milestone Oct 12, 2023
Andreagit97
Andreagit97 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

/approve

@poiana
Copy link
Contributor

poiana commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, geraldcombs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 5640134 into falcosecurity:master Oct 12, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andreagit97 Andreagit97 Andreagit97 approved these changes

@FedeDP FedeDP FedeDP approved these changes

@Kaizhe Kaizhe Awaiting requested review from Kaizhe

@leogr leogr Awaiting requested review from leogr

Assignees

@FedeDP FedeDP

@Andreagit97 Andreagit97

Labels
approved dco-signoff: yes kind/documentation lgtm release-note size/XS
Projects
Falco Roadmap
Archived in project
Milestone
0.37.0
Development

Successfully merging this pull request may close these issues.
4 participants
@geraldcombs @poiana @FedeDP @Andreagit97