Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding explanatory text to _infographics/climate/climate-change-scheme.md #10

Merged
merged 6 commits into from
Nov 16, 2022
Merged

Adding explanatory text to _infographics/climate/climate-change-scheme.md #10

merged 6 commits into from
Nov 16, 2022

Conversation

willemfrishert
Copy link

@willemfrishert willemfrishert commented Oct 26, 2022

Pilot adding English explanatory texts: #9

What does this PR do?

  • bulk-translated the Czech text to English using Google Translate for climate-change-scheme.md
  • Proofread the English text and correct it to sound natural

Open questions:

  1. The Czech page has 3 preview boxes. I could only locate one of the 3 preview boxes.
  • I managed to link the English page to "slug=fossil-fuels-emissions" for the first preview
  • The second preview links to "slug=cykly-koncentrace-co2" and there does not seem to be an equivalent for English (yet)?
  • The third preview links to the explainer "slug=vymirani-koralovych-utesu". There are no explainers in English (yet)?

What should we do with the second and third preview?
2. The Czech page points to most English Wikipedia pages except for the one on the green house effect. I redirected that one to the English Wikipedia article to provide the reader with a primer.

@mukrop
Copy link
Member

mukrop commented Nov 6, 2022

Hello @willemfrishert! Sorry for a longer reply time.

In general, great job! A few minor comments and answers to your questions below.

Your questions and content

  • For the two preview boxes, there are really no English translations yet. For the moment, keep the preview box links commented out in the source code and when they'll exist in English, we'll uncomment them.
  • Redirecting the link to Czech Wikipedia to point to the English equivalent page is exactly what was necessary to do, good thinking.
  • There still are two internal links in the text you did not comment on (as they still point to slugs used in CZ site, they break the build – you should be able to see the problem also in the Travis log).
  • Regarding the links from above: One links the infographic on O2 cycles that is not yet available in English. Again, let's just comment the link out, The second links to the map of global temperature change that is already published in English. Thus, just point the link to the English one. Doing these two things should fix the build.

Other comments

  • I was testing running Grammarly on the text and I was pleasantly surprised by the result! I happen to have a pro license, but the free one also had several relevant suggestions :-). This is the only change I did directly in your branch.
  • To replicate tests locally (e.g. checking internal links), you can run make check. The first set of tests has to pass (internal links to pages and images), while the second one is just informative (that checks availability of all external links – insights can be gained from it but we cannot guarantee their availability).
  • You can see that HTML comments (<!-- and -->) cause an end of block and thus some small whitespace issues (there is unintended indentation in places where the preview box lies in code). To eliminate this, you can use the Jekyll comments {%- comment -%} xxxxxx {%- endcomment -%}. It's just a nitpick, definitely not a publication blocker.
  • Since adding a supplementary text is a significant change, I'd suggest adjusting the published date in the header.

@willemfrishert
Copy link
Author

Hi @mukrop, thanks for the feedback!

Thanks for the heads up on Grammarly. I'll see if I can get a free copy installed as it'll be a good aid to review the translated texts. I appreciate the pass you did and changes you made on top using Grammerly on your side.

A few updates from my side based on your suggestions:

  • I replicated the issues highlighted by Travis using make check. Great to have automation on this part.
  • I replaced the HTML comment tags I used to comment out the Jekyll preview boxes by Liquid template comment tags. I noticed that the Liquid whitespace controls aren't needed. The paragraphs start to appear nicely connected so instead of {%- comment -%} xxxxxx {%- endcomment -%}, I used {% comment %} xxxxxx {% endcomment %}. Let me know if you want me to have another look at it in case I missed something?
  • I updated the published date in the header of the climate-change-scheme.md

Hope you can have another look at reviewing these changes?

@mukrop
Copy link
Member

mukrop commented Nov 16, 2022

Hi @willemfrishert,
Great job, thanks for the adjustments. At the moment, I see no other changes necessary. Thus, I'm merging the pull request (the deploy is automatic, you should be able to see you work online in a matter of minutes).

(Indeed, the Liquid whitespace controls were not needed in this case – but I appreciate the effort to investigate the matter properly!)

As for further cooperation, I'll write options in the email :-).

@mukrop mukrop merged commit 5afa5a3 into faktaoklimatu:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants