Allow to disable digits
in Faker::Internet.password
method
#3033
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Currently, a
digit
is always added to the string generated byFaker::Interner.password
. There's currently no way to disable this behavior.Also, with the current behavior, running
Faker::Internet.password(min_length: 2, max_length: 2, mix_case: true)
will return a password of length 3, as a digit is always added to the string, in addition to the uppercase and lowercase letters.Changes proposed in this pull request
This PR allows to disable the use of digits (and the auto-addition of one) when generating passwords. By default, a digit is added, but this can be disabled by setting the
digits
option tofalse
. Also, when thedigits
option is set totrue
(current and default behavior), the required length of the password is updated to reflect the presence of the digit.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
If you're proposing a new generator or locale:
[ ] Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.[ ] You've reviewed and followed the Contributing guidelines.Closing notes
I'm open to any feedback or suggestions on how to improve this PR if this idea makes sense.
Thank you very much!