Correct Faker::Address.city and Faker::Address.street_address data for :fr locale #3018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @brupla6126 do you mind running this formatter first? https://github.com/faker-ruby/faker/blob/main/CONTRIBUTING.md#yaml-files without this format, it's really hard to review this. This is one of the files that are missing this reformat. Thank you! |
brupla6126
force-pushed
the
fix_fr_address_city_and_street_translations
branch
from
b651d6c to
55fad8c
Compare
Hey @stefannibrasil I formatted the file but I noticed that many other locale files are unformatted. Maybe a rake task that will format all locale files at once? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Our Rails app test suite validations are frequently failing when using :fr locale due to
1 - Numbers in city names
2 - Extra space in street names
Faker::Address.city
Faker::Address.street_address