Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying multiple line selection blocks #2551

Merged
merged 4 commits into from
Dec 22, 2024
Merged

Allow specifying multiple line selection blocks #2551

merged 4 commits into from
Dec 22, 2024

Conversation

facelessuser
Copy link
Owner

Resolves #2385

@gir-bot gir-bot added S: needs-review Needs to be reviewed and/or approved. C: docs Related to documentation. C: snippets Related to the snippets extension. C: source Related to source code. C: tests Related to testing. labels Dec 22, 2024
shaedrich
shaedrich reviewed Dec 22, 2024
View reviewed changes
Copy link

@shaedrich shaedrich left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not that fluent in Python but I'll leave it here in case, I actually stumbled about something by chance :)

pymdownx/snippets.py Outdated Show resolved Hide resolved
shaedrich
shaedrich reviewed Dec 22, 2024
View reviewed changes
pymdownx/snippets.py Outdated Show resolved Hide resolved
@facelessuser
Copy link
Owner Author

@gir-bot lgtm

@gir-bot gir-bot added S: approved The pull request is ready to be merged. and removed S: needs-review Needs to be reviewed and/or approved. labels Dec 22, 2024
@facelessuser facelessuser merged commit 55ccf79 into main Dec 22, 2024
18 checks passed
@facelessuser facelessuser deleted the feature/snippets-multi-line-block branch December 22, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaedrich shaedrich shaedrich left review comments

Assignees
No one assigned
Labels
C: docs Related to documentation. C: snippets Related to the snippets extension. C: source Related to source code. C: tests Related to testing. S: approved The pull request is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvements to snippets with multiple lines from the same file
3 participants
@facelessuser @shaedrich @gir-bot