Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some issues with averaging #443

Merged
merged 13 commits into from
Dec 5, 2024
Merged

Fix some issues with averaging #443

merged 13 commits into from
Dec 5, 2024

Conversation

facelessuser
Copy link
Owner

@facelessuser facelessuser commented Dec 4, 2024 •
edited
Loading

  • Apply premultiplication to hues as they are being averaged in Cartesian coordinates.
  • When a hue becomes undefined during averaging, the color should become achromatic.
  • Evenly distributed colors should have always produced undefined hues due to how circular means work.
  • Powerlessness should be applied to hues of achromatic colors.

Fixes #442

@facelessuser
Fix some issues with averaging
810117b 
- Apply premultiplication to hues as they are being averaged in
  Cartesian coordinates.
- When a hue becomes undefined during averaging, the color should
  become achromatic.
- Evenly distributed colors should have always produced undefined hues
  due to how circular means work.
- Undefined alpha should apply to premultiplicated channels as zero.
@gir-bot gir-bot added S: needs-review Needs to be reviewed and/or approved. C: docs Related to documentation. C: infrastructure Related to project infrastructure. C: source Related to source code. C: tests Related to testing. labels Dec 4, 2024
@facelessuser
Fix mypy
f616550
@facelessuser
Fix lint
ea4355e
@facelessuser
Add tests to cover new handling and fix related issues
e229776
@facelessuser
Fix parameter typo
61e94bb
@facelessuser
Check once
2249257
@facelessuser
Ensure undefined alpha is treated as expected
ba45d69
@facelessuser
Average changes
1559c45 
- Update achromatic threshold
- Undefined alpha does not apply premultiplication
- Avoid processing color components of fully transparent colors, even
  when premultiplication is disabled.
- Don't overwrite saturation/chroma if undefined
- Remove powerless option and make it always active for averaging.
  Deprecate the parameter.
@facelessuser
Update average tool
99e559e
@facelessuser
Bump version
c133e06
@facelessuser
Update docs
d237102
@facelessuser
Fix spelling and lint and types
7c57780
@facelessuser
Fix test coverage
74b619b
@facelessuser
Copy link
Owner Author

@gir-bot lgtm

@gir-bot gir-bot added S: approved The pull request is ready to be merged. and removed S: needs-review Needs to be reviewed and/or approved. labels Dec 5, 2024
@facelessuser facelessuser merged commit 96a83a0 into main Dec 5, 2024
18 checks passed
@facelessuser facelessuser deleted the bugfix/average branch December 5, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C: docs Related to documentation. C: infrastructure Related to project infrastructure. C: source Related to source code. C: tests Related to testing. S: approved The pull request is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues with averaging in polar spaces
2 participants
@facelessuser @gir-bot