Fix #293, enable compiler warnings in debug mode.

facebookresearch · Dec 16, 2021 · 9cecc6d · 9cecc6d
1 parent 434338d
commit 9cecc6d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -19,6 +19,11 @@ if(CMAKE_BUILD_TYPE MATCHES Debug)
         "${CMAKE_LINKER_FLAGS_DEBUG} -fno-omit-frame-pointer -fsanitize=address"
     )
   endif()
+  if(MSVC)
+    add_compile_options(/W4)
+  else()
+    add_compile_options(-Wall)
+  endif()
 elseif(CMAKE_BUILD_TYPE MATCHES Release)
   message("Release build.")
 else()

diff --git a/win/rl/pynethack.cc b/win/rl/pynethack.cc
@@ -104,8 +104,7 @@ class Nethack
 
     Nethack(std::string dlpath, std::string hackdir,
             std::string nethackoptions, bool spawn_monsters)
-        : dlpath_(std::move(dlpath)), obs_{}, settings_{},
-          spawn_monsters_(spawn_monsters)
+        : dlpath_(std::move(dlpath)), obs_{}, settings_{}
     {
         if (hackdir.size() > sizeof(settings_.hackdir) - 1) {
             throw std::length_error("hackdir too long");
@@ -325,7 +324,6 @@ class Nethack
     std::vector<py::object> py_buffers_;
     nle_seeds_init_t seed_init_;
     bool use_seed_init = false;
-    bool spawn_monsters_ = true;
     nledl_ctx *nle_ = nullptr;
     std::FILE *ttyrec_ = nullptr;
     nle_settings settings_;