Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Commit

Permalink
Remove seeds from internal observation, add warning.
Browse files Browse the repository at this point in the history
Unfortunately, xwaitforspace is in internal currently and it is
somewhat useful when auto-skipping of messages isn't turned on.
  • Loading branch information
Heinrich Kuttler committed Jun 16, 2021
1 parent fc8e272 commit 7e799c7
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
6 changes: 6 additions & 0 deletions nle/env/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,12 @@ def __init__(

self._observation_keys = list(observation_keys)

if "internal" in self._observation_keys:
logger.warn(
"""The 'internal' NLE observation was requested.
This might contain data that shouldn't be abailable to agents."""
)

# Observations we always need.
for key in (
"glyphs",
Expand Down
2 changes: 1 addition & 1 deletion version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.7.0
0.7.1
4 changes: 2 additions & 2 deletions win/rl/winrl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,8 @@ NetHackRL::fill_obs(nle_obs *obs)
obs->internal[2] = in_getlin;
obs->internal[3] = xwaitingforspace;
obs->internal[4] = stairs_down;
obs->internal[5] = nle_seeds[0]; /* core */
obs->internal[6] = nle_seeds[1]; /* disp */
obs->internal[5] = 0; /* used to be core seed */
obs->internal[6] = 0; /* used to be disp seed */
obs->internal[7] = u.uhunger;
obs->internal[8] =
u.urexp; /* score (careful! check botl_score() and end.c) */
Expand Down

0 comments on commit 7e799c7

Please sign in to comment.