Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversion code to the BOP format #12

Closed
wants to merge 28 commits into from

Conversation

AnasIbrahim
Copy link
Contributor

@AnasIbrahim AnasIbrahim commented Sep 10, 2024

This PR contains 3 scripts to convert the HOT3D-Clips dataset from its native format to the BOP format. The BOP format had to be extended because the original format only included RGB and depth modalities. This extension made it possible to include a varying number of modalities (RGB, gray1, gray2) with separate annotations for each modality. The dataset has already been converted using these scripts and uploaded to the BOP website. These scripts went through several revisions, as the conversion process required multiple changes to adapt the dataset to the new standard format, which was initially not strictly defined and required frequent adjustments. The scripts in this PR are isolated and do not make any changes to the existing code in the repository.

The 3 Scripts are:

  1. hot3d_models_to_bop.py : Script that converts the 3D object (full) models from the GLTF format to the PLY format
  2. hot3d_models_eval_to_bop.py: Script to convert the eval object model
  3. hot3d_clips_to_bop_scenewise.py: Script to convert the dataset itself

AnasIbrahim and others added 25 commits July 29, 2024 12:34
…cene camera. Remove wrong dict key scene_camera
…r object without a texture map (solid color objects)
…script to extract model info from hot3d model info.
@facebook-github-bot
Copy link
Contributor

Hi @AnasIbrahim!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@SeaOtocinclus
Copy link
Contributor

Thank you @AnasIbrahim,

  • can you start the process with signing the Facebook CLA and add a description to the text of your PR?

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 10, 2024
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@AnasIbrahim
Copy link
Contributor Author

I added the description and signed the license.

@facebook-github-bot
Copy link
Contributor

@SeaOtocinclus has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@@ -0,0 +1,329 @@
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All files must have a header related to licensing of the project

# Copyright (c) Meta Platforms, Inc. and affiliates.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the license. I also fixed an existing problem with the generation of out-of-frame-scope masks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AnasIbrahim, I will fix the linting issue.

@facebook-github-bot
Copy link
Contributor

@SeaOtocinclus has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@AnasIbrahim
Copy link
Contributor Author

AnasIbrahim commented Sep 16, 2024

@SeaOtocinclus I just made a trivial change to the argparse input parameters. To make it easier to automate the conversion on the BOP server.

@facebook-github-bot
Copy link
Contributor

@SeaOtocinclus has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@SeaOtocinclus
Copy link
Contributor

@AnasIbrahim Look good to me, I will merge.

@facebook-github-bot
Copy link
Contributor

@SeaOtocinclus merged this pull request in 1d766a3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants