Add remove ids for indexrefine #4026
Conversation
add remove for refine
Update IndexRefine.h
|
Hi @Tickdack! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Co-authored-by: gtwang01 <[email protected]>
|
@gtwang01 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Can you add some unit tests to ensure reliability? |
ok,i will add unit tests |
|
It seems like from this implementation that if the base index's remove_ids works but the refine index's throws, then we end up in a state where the base index and refine index are no longer in sync and are no longer useful. Is there any way to prevent this? At the very least, to notify the user if such a thing has happened and what it means? I think the user would essentially have to recreate the index if this happens. |
I think some index in faiss not support remove, and use try catch to remind users. so i think it is reasonable |
|
What's the status on unit testing? |
No description provided.