Warm start a stratey based on config provided seed conditions #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Update db master table spec such that experiment ID and participant is not unique. Functions that used experiment_id as a key have been swapped to use the master table's master key (unique_id). Functions appeared to expect that it's possible to get multiple entries back from a single experiment ID existed but didn't make sense since it was unique, this means nothing really needs to be changed. Replay functions used to leverage the experiment_id, here it is assumed to be unique, which it was. Now replay functions use the master table's unique_id to pick which experiment to replay, which conveniently also means it's a lot easier to just try integers starting from 0 (instead of finding a uuid). Metadata reading has been changed to correctly get all the information from the config to match the master table spec. These are technically breaking changes that may affect old scripts but it's not clear what db utility functions may be used in weird scripts trying to use experiment_ids to identify experiments. Still old dbs should all work and be compatible. Differential Revision: D66526187
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66731597 |
unrealdev12
added a commit
to unrealdev12/aepsych
that referenced
this pull request
Dec 19, 2024
…okresearch#487) Summary: Pull Request resolved: facebookresearch#487 There is a desire to warm start a strategy with data filtered on master table values recorded from previous experiments. Data can be filtered on any data other than master.unique_id. This means that the below are all valid filter criteria: - experiment_name - experiment_description - experiment_id - participant_id - anything stored in extra_metadata Criteria will follow AND logic between fields, but inclusive OR logic within the same field. Data will be further filtered out if it does not meet these criteria: - Each parameter matches on name and type - Each outcome matches on name and type - Stimuli per trial are the same Differential Revision: D66731597
unrealdev12
force-pushed
the
export-D66731597
branch
from
21dd86e to
c0016b9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66731597 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D66731597 |
unrealdev12
force-pushed
the
export-D66731597
branch
from
c0016b9 to
c9ee936
Compare
unrealdev12
added a commit
to unrealdev12/aepsych
that referenced
this pull request
Dec 19, 2024
…okresearch#487) Summary: Pull Request resolved: facebookresearch#487 There is a desire to warm start a strategy with data filtered on master table values recorded from previous experiments. Data can be filtered on any data other than master.unique_id. This means that the below are all valid filter criteria: - experiment_name - experiment_description - experiment_id - participant_id - anything stored in extra_metadata Criteria will follow AND logic between fields, but inclusive OR logic within the same field. Data will be further filtered out if it does not meet these criteria: - Each parameter matches on name and type - Each outcome matches on name and type - Stimuli per trial are the same Differential Revision: D66731597
|
This pull request was exported from Phabricator. Differential Revision: D66731597 |
unrealdev12
added a commit
to unrealdev12/aepsych
that referenced
this pull request
Dec 20, 2024
…okresearch#487) Summary: Pull Request resolved: facebookresearch#487 There is a desire to warm start a strategy with data filtered on master table values recorded from previous experiments. Data can be filtered on any data other than master.unique_id. This means that the below are all valid filter criteria: - experiment_name - experiment_description - experiment_id - participant_id - anything stored in extra_metadata Criteria will follow AND logic between fields, but inclusive OR logic within the same field. Data will be further filtered out if it does not meet these criteria: - Each parameter matches on name and type - Each outcome matches on name and type - Stimuli per trial are the same Differential Revision: D66731597
unrealdev12
force-pushed
the
export-D66731597
branch
from
c9ee936 to
90efa22
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66731597 |
unrealdev12
force-pushed
the
export-D66731597
branch
from
90efa22 to
0bf8ed4
Compare
unrealdev12
added a commit
to unrealdev12/aepsych
that referenced
this pull request
Dec 20, 2024
…okresearch#487) Summary: Pull Request resolved: facebookresearch#487 There is a desire to warm start a strategy with data filtered on master table values recorded from previous experiments. Data can be filtered on any data other than master.unique_id. This means that the below are all valid filter criteria: - experiment_name - experiment_description - experiment_id - participant_id - anything stored in extra_metadata Criteria will follow AND logic between fields, but inclusive OR logic within the same field. Data will be further filtered out if it does not meet these criteria: - Each parameter matches on name and type - Each outcome matches on name and type - Stimuli per trial are the same Differential Revision: D66731597
unrealdev12
force-pushed
the
export-D66731597
branch
from
0bf8ed4 to
a361adb
Compare
unrealdev12
added a commit
to unrealdev12/aepsych
that referenced
this pull request
Dec 20, 2024
…okresearch#487) Summary: Pull Request resolved: facebookresearch#487 There is a desire to warm start a strategy with data filtered on master table values recorded from previous experiments. Data can be filtered on any data other than master.unique_id. This means that the below are all valid filter criteria: - experiment_name - experiment_description - experiment_id - participant_id - anything stored in extra_metadata Criteria will follow AND logic between fields, but inclusive OR logic within the same field. Data will be further filtered out if it does not meet these criteria: - Each parameter matches on name and type - Each outcome matches on name and type - Stimuli per trial are the same allow-large-files Differential Revision: D66731597
|
This pull request was exported from Phabricator. Differential Revision: D66731597 |
unrealdev12
added a commit
to unrealdev12/aepsych
that referenced
this pull request
Dec 20, 2024
…okresearch#487) Summary: Pull Request resolved: facebookresearch#487 There is a desire to warm start a strategy with data filtered on master table values recorded from previous experiments. Data can be filtered on any data other than master.unique_id. This means that the below are all valid filter criteria: - experiment_name - experiment_description - experiment_id - participant_id - anything stored in extra_metadata Criteria will follow AND logic between fields, but inclusive OR logic within the same field. Data will be further filtered out if it does not meet these criteria: - Each parameter matches on name and type - Each outcome matches on name and type - Stimuli per trial are the same allow-large-files Differential Revision: D66731597
unrealdev12
force-pushed
the
export-D66731597
branch
from
a361adb to
0969773
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66731597 |
unrealdev12
added a commit
to unrealdev12/aepsych
that referenced
this pull request
Dec 20, 2024
…okresearch#487) Summary: Pull Request resolved: facebookresearch#487 There is a desire to warm start a strategy with data filtered on master table values recorded from previous experiments. Data can be filtered on any data other than master.unique_id. This means that the below are all valid filter criteria: - experiment_name - experiment_description - experiment_id - participant_id - anything stored in extra_metadata Criteria will follow AND logic between fields, but inclusive OR logic within the same field. Data will be further filtered out if it does not meet these criteria: - Each parameter matches on name and type - Each outcome matches on name and type - Stimuli per trial are the same allow-large-files Differential Revision: D66731597
unrealdev12
force-pushed
the
export-D66731597
branch
from
0969773 to
a78ee13
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66731597 |
unrealdev12
added a commit
to unrealdev12/aepsych
that referenced
this pull request
Dec 20, 2024
…okresearch#487) Summary: Pull Request resolved: facebookresearch#487 There is a desire to warm start a strategy with data filtered on master table values recorded from previous experiments. Data can be filtered on any data other than master.unique_id. This means that the below are all valid filter criteria: - experiment_name - experiment_description - experiment_id - participant_id - anything stored in extra_metadata Criteria will follow AND logic between fields, but inclusive OR logic within the same field. Data will be further filtered out if it does not meet these criteria: - Each parameter matches on name and type - Each outcome matches on name and type - Stimuli per trial are the same allow-large-files Differential Revision: D66731597
|
This pull request was exported from Phabricator. Differential Revision: D66731597 |
unrealdev12
force-pushed
the
export-D66731597
branch
from
a78ee13 to
9d35c6f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66731597 |
unrealdev12
added a commit
to unrealdev12/aepsych
that referenced
this pull request
Dec 20, 2024
…okresearch#487) Summary: Pull Request resolved: facebookresearch#487 There is a desire to warm start a strategy with data filtered on master table values recorded from previous experiments. Data can be filtered on any data other than master.unique_id. This means that the below are all valid filter criteria: - experiment_name - experiment_description - experiment_id - participant_id - anything stored in extra_metadata Criteria will follow AND logic between fields, but inclusive OR logic within the same field. Data will be further filtered out if it does not meet these criteria: - Each parameter matches on name and type - Each outcome matches on name and type - Stimuli per trial are the same allow-large-files Differential Revision: D66731597
unrealdev12
force-pushed
the
export-D66731597
branch
from
9d35c6f to
040ebc1
Compare
…okresearch#487) Summary: Pull Request resolved: facebookresearch#487 There is a desire to warm start a strategy with data filtered on master table values recorded from previous experiments. Data can be filtered on any data other than master.unique_id. This means that the below are all valid filter criteria: - experiment_name - experiment_description - experiment_id - participant_id - anything stored in extra_metadata Criteria will follow AND logic between fields, but inclusive OR logic within the same field. Data will be further filtered out if it does not meet these criteria: - Each parameter matches on name and type - Each outcome matches on name and type - Stimuli per trial are the same allow-large-files Differential Revision: D66731597
|
This pull request was exported from Phabricator. Differential Revision: D66731597 |
unrealdev12
force-pushed
the
export-D66731597
branch
from
040ebc1 to
b53af2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There is a desire to warm start a strategy with data filtered on master table values recorded from previous experiments.
Data can be filtered on any data other than master.unique_id. This means that the below are all valid filter criteria:
Criteria will follow AND logic between fields, but inclusive OR logic within the same field.
Data will be further filtered out if it does not meet these criteria:
Differential Revision: D66731597