Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix func declaration #422

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

Zehui-Lin
Copy link

No description provided.

@facebook-github-bot
Copy link
Contributor

Hi @Zehui-Lin!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 28, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@haooooooqi haooooooqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Zehui-Lin for fixing the comments! Really nice to have it! Thanks :)

@facebook-github-bot
Copy link
Contributor

@haooooooqi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@lyttonhao lyttonhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Shall we also fix some comments for return values?

slowfast/datasets/transform.py Show resolved Hide resolved
slowfast/datasets/transform.py Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@Zehui-Lin has updated the pull request. You must reimport the pull request before landing.

@Zehui-Lin
Copy link
Author

Of course, thanks @lyttonhao for the suggestions. :)

@facebook-github-bot
Copy link
Contributor

@Zehui-Lin has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@haooooooqi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Zehui-Lin has updated the pull request. You must reimport the pull request before landing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants