Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Pass experiment object to algorithm #31

Merged
merged 11 commits into from
Oct 21, 2023
Merged

[Refactor] Pass experiment object to algorithm #31

merged 11 commits into from
Oct 21, 2023

Conversation

matteobettini
Copy link
Collaborator

@matteobettini matteobettini commented Oct 20, 2023 •
edited
Loading

This PR makes it so that the whole experiment object is passed to algorithms in order to increment the available inoformation to a user implementing a custom algoritim.

Furtermore it:

  • makes the scale transformation in probabilistic algorithms customizable by the user
  • allow models to access the action spec

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 20, 2023
@matteobettini matteobettini added the smacv2 Label to be assigned to run the SMACv2 tests label Oct 20, 2023
@matteobettini matteobettini marked this pull request as ready for review October 21, 2023 13:00
@matteobettini matteobettini changed the title [Refactor] Pass experiment object to components [Refactor] Pass experiment object to algorithm Oct 21, 2023
@matteobettini matteobettini merged commit 8f26dd2 into main Oct 21, 2023
12 checks passed
@matteobettini matteobettini deleted the components_more_visibility branch October 21, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. smacv2 Label to be assigned to run the SMACv2 tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matteobettini @facebook-github-bot