fix bug on unknown field

Summary:
When a user gives a bad field name, it exposes a bug in `Struct.__init__`.
```
File "thrift.python/types.pyx", line 1118, in thrift.python.types.Struct.__call__
TypeError: 'dict_keys' object is not subscriptable
```

Instead of subscripting keys, just format all the bad keys as a list.

Reviewed By: yoney

Differential Revision: D67347012

fbshipit-source-id: 1bddf24505d0602a824535785c46e9f143defac3

third-party/thrift/src/thrift/lib/python/test/structs.py

@@ -71,7 +71,6 @@
     to_thrift_set,
 )
 
-from thrift.python.serializer import deserialize, serialize_iobuf
 from thrift.python.types import isset, update_nested_field
 
 ListT = TypeVar("ListT")
@@ -304,6 +303,14 @@ def test_call_replace(self) -> None:
         self.assertIsNone(x.name)
         self.assertIsNotNone(x.an_int)
 
+    def test_call_bad_key(self) -> None:
+        x = self.easy()
+
+        err_type = AttributeError if self.is_mutable_run else TypeError
+        with self.assertRaisesRegex(err_type, "'easy' object .* attribute.* 'bad_key'"):
+            # pyre-ignore[28]: bad key for test
+            x = x(bad_key="foo")
+
     def test_reserved(self) -> None:
         x = self.Reserved(
             from_="hello",

third-party/thrift/src/thrift/lib/python/types.pyx

@@ -1114,8 +1114,8 @@ cdef class Struct(StructOrUnion):
             set_struct_field(new_inst._fbthrift_data, field_index, value_to_copy)
         if kwargs:
             raise TypeError(
-                f"{type(self)}: error updating copy with unknown field: "
-                f"'{kwargs.keys()[0]}'"
+                f"'{type(self).__name__}' object does not have attribute(s): "
+                f"'{', '.join(kwargs.keys())}'"
             )
         new_inst._fbthrift_populate_primitive_fields()
         return new_inst