Add test to ensure IndexOutOfBoundsException is thrown for structs wi…

…th no STOP tag

Summary: This is a followup to D63777839, which ensures that malformed structs missing a STOP tag/byte don't end up in an infite loop. They now cause the serializer to throw when a malformed input is used with an InputStream.

Reviewed By: avalonalex

Differential Revision: D63800844

fbshipit-source-id: 31624306e0fdd8e3e5097cff8752f8d8070b8677

thrift/lib/java/runtime/src/test/java/com/facebook/thrift/util/SerializerUtilTest.java

@@ -17,6 +17,8 @@
 package com.facebook.thrift.util;
 
 import com.facebook.thrift.test.EveryLayout;
+import com.facebook.thrift.test.universalname.TestRequest;
+import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
 import java.io.InputStream;
 import java.nio.ByteBuffer;
@@ -92,6 +94,24 @@ public void testToAndFromStreams() throws Exception {
     Assert.assertEquals(this.everyLayout, everyLayout);
   }
 
+  @Test(expected = IndexOutOfBoundsException.class)
+  public void testBadDataWithoutStopTagThrowsIndexOutOfBoundsException() {
+    ByteBuffer in =
+        SerializerUtil.toByteBuffer(
+            new TestRequest.Builder().setAString("abcd").build(), SerializationProtocol.TCompact);
+
+    // Remove Trailing byte tha would normally indicate STOP
+    byte[] slice = new byte[in.capacity() - 1];
+    in.get(slice, 0, in.capacity() - 1);
+
+    // Use ByteArrayInputStream to simulate use of input stream
+    TestRequest everyLayout =
+        SerializerUtil.fromInputStream(
+            TestRequest.asReader(),
+            new ByteArrayInputStream(slice),
+            SerializationProtocol.TCompact);
+  }
+
   @Test
   public void testToOutputStream() {
     ByteArrayOutputStream bos = new ByteArrayOutputStream();