check that transport is always specified when calling thrift.NewClient

Summary:
check that transport is always specified when calling thrift.NewClient

This way we can be sure that thrift.NewClient is never called without thrift.WithHeader or thrift.WithUpgradeToRocket

We can then be sure that we have upgraded all users of thrift.WithHeader to thrift.WithUpgradeToRocket, when we are ready to fully roll out the rocket client.

Reviewed By: echistyakov

Differential Revision: D63324777

fbshipit-source-id: cc3fa497fae1ec587e637f4d8c4908d48236c26c

thrift/lib/go/thrift/client_options.go

@@ -155,14 +155,17 @@ func newDefaultPersistentHeaders() map[string]string {
 func newOptions(opts ...ClientOption) (*clientOptions, error) {
 	res := &clientOptions{
 		protocol:          types.ProtocolIDCompact,
-		transport:         TransportIDHeader,
+		transport:         TransportIDUnknown,
 		persistentHeaders: newDefaultPersistentHeaders(),
 	}
 	for _, opt := range opts {
 		if err := opt(res); err != nil {
 			return nil, err
 		}
 	}
+	if res.transport == TransportIDUnknown {
+		panic(NewTransportException(types.NOT_SUPPORTED, "no transport specified! Please use thrift.WithHeader() or thrift.WithUpgradeToRocket() in the thrift.NewClient call"))
+	}
 	return res, nil
 }