janga: config: modify pmUnitName and adjust SMB_U337_PMBUS_1 & SMB_U177_PMBUS_2 #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdo8736
approved these changes
Oct 16, 2024
|
Thank you. |
|
@kimdo8736 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kimdo8736 merged this pull request in a715823. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for janga 2nd source sensor service.
Motivation
1.In platform such common sensors: “SMB_E1S_SSD_TEMP”, “SMB_U104_OUTER_LM75_TEMP”, “SMB_U15_OSFP_OUTER_LM75_TEMP” we put them in pmUnitName JANGA, SMB only exist versioned sensors to avoid redundancy.
2.We have checked the email info and found we do not need to change platform config just change sensor config.
3.So I moved common SMB sensors to pmUnitName JANGA according to platform config(In this PR i did not change platform config,just following the platform config structure).
4.Added SMB_U337_PMBUS_1 and SMB_U177_PMBUS_2 configs for every SMB main source and SMB 2nd source,because they are versioned sensors missed it before.
5.Adjusted "RUNBMC" pmUnitName to "MINERVA_BMC".
Test Plan
1.The correctness of the format has been verified on this website https://jsonlint.com/
2.Used jq cmd to pretty the format.
3.Test log as follows:
Tested both in janga dvt main source & janga dvt 2nd source machine.
janga 2nd source tested log:
janga main source tested log:
janga_dvt_2nd_platform_10_12_test.txt
janga_dvt_2nd_sensor_10_12_test.txt
janga_dvt_main_source_platform_10_12_test.txt
janga_dvt_main_source_sensor_10_12_test.txt