Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

segbits_hclk_ioi: fix missing ONLY_DIFF_IN_USE #2249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

segbits_hclk_ioi: fix missing ONLY_DIFF_IN_USE #2249

wants to merge 1 commit into from

Conversation

hansfbaier
Copy link
Collaborator

I think the comment in the code is pretty much explaining the fix.

@hansfbaier
Copy link
Collaborator Author

Now the mentioned comment is gone, because I fixed the problem at the source.
Not generating the LVDS_IN_USE tag will get rid of it.

@hansfbaier
Copy link
Collaborator Author

Problem was, since LVDS is the only ONLY_DIFF IO standard on the high performance banks, ONLY_DIFF_IN_USE and LVDS_IN_USE are synomynous, which means they have the same bits, and that's why dbfixup removed both.

hansfbaier added a commit to openXC7/prjxray-db that referenced this pull request Oct 12, 2023
@hansfbaier
segbits_hclk_ioi.db: add missing HCLK_IOI.ONLY_DIFF_IN_USE, see f4pga…
dfa3712 
…/prjxray#2249
@hansfbaier
Copy link
Collaborator Author

@mithro Can this be merged? All relevant tests are green, and this is a change to the code I contributed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hansfbaier