create henson plugin #185
Merged
create henson plugin #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs, variants + add custom dependencies to each configuration. The navigation api is compiled correctly, jared correctly, it contains the model, the intent builder and henson (for now). The main source set itself dependsn on the api. All artifacts related to dart and henson are handled automatically
stephanenicolas
force-pushed
the
sni/create-henson-plugin
branch
6 times, most recently
from
310df87 to
8123766
Compare
dlemures
approved these changes
Dec 1, 2017
…generate a henson navigator class. Some details need to be enhanced like the generated file location, the variant. But it works. Do we need a third source set to generate into ?
…better than before
…uilders the principle woks. I can detect the navigation api dependencies and …
…/dart into sni/create-henson-plugin
kshirsagarps
reviewed
Dec 1, 2017
| //it will be used later by the plugin to add the proper version of | ||
| //dependencies to the project that uses the plugin | ||
| def prop = new Properties() | ||
| def propFile = new File("${project.rootDir}/henson-plugin/src/main/resources/build.properties") |
There was a problem hiding this comment.
Does the D&H version go here? If so, would be nice to use it for the composite builds needed for D&H sample.
There was a problem hiding this comment.
Yes, if there is no better way to do it.
|
|
||
| //the main source set | ||
| def suffix = "" | ||
| def pathSuffix = "main/" |
There was a problem hiding this comment.
Can some of this be constants?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#164 : this is the first PR to create the henson-plugin: it should work. There is a functional test, but really not so precise yet.
The plugin allows to add a new source set that will contain the models for dart&henson 3 navigation.
The navigation source set is located in 'src/navigation/java/'.
Each build type, flavor and variant can use a specific navigation source set. The source set should contain models only and will be processed by the dart & henson APs. It will expose a
navigationApiconfiguration for a module using the plugin. This artifact will be a jar containing intent builders and the henson class, the extra binder, and the model class itself.The plugin also adds automatically the navigation jar to the dependencies of the main source set.
See https://github.groupondev.com/snicolas/Henson_structure for an example
The plugin also manages the dependencies to dart, using the right annotation processors on the new navigation source set. The only things users have to do are :
src/navigation/java(or any variant aware equivalent such assrc/navigation/red/javaorsrc/navigation/debug/javaorsrc/navigation/red/debug/java.navigationApi,redNavigationApi,debugNavigationApi,redDebugNavigationApi. All android scopes are supported: Api, Implementation, compileOnly and annotationProcessor.The plugin is roughly unit tested for now.