Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fabfile with new deployment #535

Open
wants to merge 6 commits into
base: next
Choose a base branch
from

Conversation

krestenlaust
Copy link
Member

@krestenlaust krestenlaust commented Dec 2, 2024

I don't think it is necessary to reload apache2.service anymore 🤔

Copy link
Member Author

@krestenlaust krestenlaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried not overcomplicating the file

Comment on lines +7 to +8
sudo("systemctl stop stregsystem.socket")
sudo("systemctl stop stregsystem.service")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to shutdown both of them?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it should only be necessary to stop stregsystem.socket

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens to the existing stregsystem.service? Or is it only active during a request

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo, whooops. I meant to say that it should only be necessary to shut down stregsystem.service. To answer your question, it keeps running once started

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, what happens if apache2 tries to invoke stregsystem.socket during a deployment, then?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I guess it's best to keep the systemctl stop stregsystem.socket then

fabfile.py Show resolved Hide resolved
fabfile.py Outdated Show resolved Hide resolved
@krestenlaust krestenlaust marked this pull request as ready for review December 2, 2024 23:47
fabfile.py Outdated Show resolved Hide resolved
@@ -4,12 +4,14 @@
@task
def deploy():
with cd("/data/stregsystem"):
sudo("systemctl stop apache2.service")
sudo("systemctl stop stregsystem.socket")
sudo("systemctl stop stregsystem.service")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the stregsystem.socket and stregsystem.service systemd files located in the repository too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They actually aren't 😓 , do you have an idea for where to store them? Currently, they are just on the server

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merry christmas also 🎅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants