Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fnugfald razzia #381

Merged
merged 11 commits into from
Nov 3, 2023
Merged

Fnugfald razzia #381

merged 11 commits into from
Nov 3, 2023

Conversation

krestenlaust
Copy link
Member

@krestenlaust krestenlaust commented Nov 2, 2023

People shan't get beer more often than every 30 minutes, and people need to have bought a ticket.

Related to #330

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #381 (004c568) into next (add394b) will decrease coverage by 0.40%.
The diff coverage is 48.78%.

❗ Current head 004c568 differs from pull request most recent head 7f2e483. Consider uploading reports for the commit 7f2e483 to get more accurate results

@@            Coverage Diff             @@
##             next     #381      +/-   ##
==========================================
- Coverage   53.89%   53.49%   -0.40%     
==========================================
  Files          33       33              
  Lines        4509     4544      +35     
  Branches      265      267       +2     
==========================================
+ Hits         2430     2431       +1     
- Misses       2029     2063      +34     
  Partials       50       50              
Files Coverage Δ
stregreport/models.py 76.19% <100.00%> (+1.19%) ⬆️
stregreport/urls.py 12.90% <ø> (-1.92%) ⬇️
stregreport/views.py 24.15% <44.73%> (-1.53%) ⬇️

@krestenlaust
Copy link
Member Author

There's a visual issue of the boxes not aligning when a user hasn't bought a ticket, but I don't regard it as important at the moment.
Image

@krestenlaust krestenlaust marked this pull request as ready for review November 2, 2023 15:52
Copy link
Contributor

@Nobogo Nobogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda bad, we need it tomorrow though, please be "temporary"

@LucasWedel
Copy link

aint no way vi bliver øl-ratelimited på 2 i timen??

@krestenlaust
Copy link
Member Author

@LucasWedel aint no way vi bliver øl-ratelimited på 2 i timen??

Don't kill the bødel. Standard foobar procedure 🙃 you're welcome to question their methods at foobar[at]fklub.dk

@LucasWedel
Copy link

@LucasWedel aint no way vi bliver øl-ratelimited på 2 i timen??

@krestenlaust Don't kill the bødel. Standard foobar procedure 🙃 you're welcome to question their methods at foobar[at]fklub.dk

Me angery, me unhappy, me thirsty >:(

Copy link
Member

@falkecarlsen falkecarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In practice 2 beers and hour has angered very few since I implemented it originally last year https://github.com/f-klubben/stregsystemet/blob/next/stregreport/views.py#L62.

:shipit:

@krestenlaust krestenlaust merged commit 85b33b5 into f-klubben:next Nov 3, 2023
4 checks passed
krestenlaust added a commit that referenced this pull request Nov 7, 2023
@krestenlaust krestenlaust mentioned this pull request Nov 7, 2023
3 tasks
@krestenlaust krestenlaust deleted the fnugfald-hack branch February 29, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants