Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move purchase-heatmap category definitions to config file #379

Closed
wants to merge 1 commit into from

Conversation

ha36d
Copy link

@ha36d ha36d commented Oct 29, 2023

resolves #375

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

❗ No coverage uploaded for pull request base (next@5d6d103). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 5763c59 differs from pull request most recent head 6c62d4c. Consider uploading reports for the commit 6c62d4c to get more accurate results

@@           Coverage Diff           @@
##             next     #379   +/-   ##
=======================================
  Coverage        ?   53.90%           
=======================================
  Files           ?       33           
  Lines           ?     4512           
  Branches        ?      265           
=======================================
  Hits            ?     2432           
  Misses          ?     2030           
  Partials        ?       50           
Files Coverage Δ
stregsystem/purchase_heatmap.py 57.21% <100.00%> (ø)
treo/settings.py 32.86% <100.00%> (ø)

@ha36d ha36d marked this pull request as ready for review October 29, 2023 11:54
@krestenlaust
Copy link
Member

The issue has been updated to a more fitting solution. As opposed to storing it in a config file, it should be configurable in the admin panel. Sorry about the change of mind.

@krestenlaust krestenlaust marked this pull request as draft November 7, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move purchase-heatmap category definitions to django admin panel
2 participants