Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-11420] Add --what-to-test for ios submit #2310

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/eas-cli/src/commands/submit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ interface RawCommandFlags {
verbose: boolean;
wait: boolean;
'non-interactive': boolean;
'what-to-test'?: string;
'verbose-fastlane': boolean;
}

Expand All @@ -44,6 +45,7 @@ interface CommandFlags {
wait: boolean;
nonInteractive: boolean;
isVerboseFastlaneEnabled: boolean;
whatToTest?: string;
}

export default class Submit extends EasCommand {
Expand Down Expand Up @@ -93,6 +95,9 @@ export default class Submit extends EasCommand {
default: false,
description: 'Run command in non-interactive mode',
}),
'what-to-test': Flags.string({
description: 'What to test',
}),
};

static override contextDefinition = {
Expand Down Expand Up @@ -138,6 +143,7 @@ export default class Submit extends EasCommand {
profile: submissionProfile.profile,
archiveFlags: flagsWithPlatform.archiveFlags,
nonInteractive: flagsWithPlatform.nonInteractive,
whatToTest: flagsWithPlatform.whatToTest,
isVerboseFastlaneEnabled: flagsWithPlatform.isVerboseFastlaneEnabled,
actor,
graphqlClient,
Expand Down Expand Up @@ -183,6 +189,7 @@ export default class Submit extends EasCommand {
profile,
'non-interactive': nonInteractive,
'verbose-fastlane': isVerboseFastlaneEnabled,
'what-to-test': whatToTest,
...archiveFlags
} = flags;

Expand All @@ -204,6 +211,7 @@ export default class Submit extends EasCommand {
profile,
nonInteractive,
isVerboseFastlaneEnabled,
whatToTest,
};
}

Expand Down
2 changes: 2 additions & 0 deletions packages/eas-cli/src/submit/context.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export interface SubmissionContext<T extends Platform> {
vcsClient: Client;
applicationIdentifierOverride?: string;
specifiedProfile?: string;
whatToTest?: string;
}

export interface SubmitArchiveFlags {
Expand All @@ -59,6 +60,7 @@ export async function createSubmissionContextAsync<T extends Platform>(params: {
projectId: string;
vcsClient: Client;
specifiedProfile?: string;
whatToTest?: string;
}): Promise<SubmissionContext<T>> {
const {
applicationIdentifier,
Expand Down
1 change: 1 addition & 0 deletions packages/eas-cli/src/submit/ios/IosSubmitter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ export default class IosSubmitter extends BaseSubmitter<
ascAppIdentifier,
appleIdUsername,
isVerboseFastlaneEnabled,
whatToTest: this.ctx.whatToTest,
...(appSpecificPassword ? this.formatAppSpecificPassword(appSpecificPassword) : null),
...(ascApiKeyResult?.result ? this.formatAscApiKeyResult(ascApiKeyResult.result) : null),
};
Expand Down
Loading