-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] Use credentials types from eas-build-job where possible #2191
base: main
Are you sure you want to change the base?
[eas-cli] Use credentials types from eas-build-job where possible #2191
Conversation
Size Change: -2.04 kB (0%) Total Size: 51.5 MB
|
ef3448f
to
0371cfa
Compare
/changelog-entry chore Migrate to using credentials types from |
2af0295
to
12d09ea
Compare
12d09ea
to
d8e8060
Compare
✅ Thank you for adding the changelog entry! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2191 +/- ##
==========================================
+ Coverage 54.10% 54.10% +0.01%
==========================================
Files 516 516
Lines 18795 18793 -2
Branches 3769 3769
==========================================
Hits 10167 10167
+ Misses 8607 8605 -2
Partials 21 21 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks reasonable, although I would do some manual testing for different distribution types and local credentials before merging it
Why
I've noticed we have two very similar types in
eas-build
andeas-cli
. The types ineas-cli
are just intermediate — in the end, when we hand off the build request towww
we change them into theeas-build
ones.Wouldn't it be nice if we used the target types from the beginning?
How
Removed
TargetCredentials
in favor ofIos.TargetCredentials
.IosCredentials
in favor ofIos.BuildCredentials
. Basically, that's it!Also made some minor change to
credentialsJson/types
so that less types are exported so we are forced to try to use theeas-build-job
ones.Test Plan
TODO