Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/index error when unhighlighting #434

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

magdaaniol
Copy link
Collaborator

Description

The logic in unhighlight_ents_in_doc does not account for the fact that there might exist unhighlighted entities in doc, which will lead to IndexError if that's the case.

Corresponding documentation PR

Types of change

Bug fix

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran all tests in tests and usage_examples/tests, and all new and existing tests passed. This includes
    • all external tests (i. e. pytest ran with --external)
    • all tests requiring a GPU (i. e. pytest ran with --gpu)
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@magdaaniol magdaaniol requested a review from rmitsch January 29, 2024 09:23
@rmitsch rmitsch added bug Something isn't working feat/task Feature: tasks labels Jan 29, 2024
Copy link
Collaborator

@rmitsch rmitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! 🎉

@rmitsch rmitsch merged commit 2e88594 into main Jan 29, 2024
14 checks passed
@svlandeg svlandeg deleted the fix/index_error_when_unhighlighting branch January 29, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feat/task Feature: tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants