Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to ditch **kwargs #299

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Refactor to ditch **kwargs #299

merged 3 commits into from
Oct 11, 2023

Conversation

rmitsch
Copy link
Collaborator

@rmitsch rmitsch commented Sep 20, 2023

Description

Refactor to ditch **kwargs.

Corresponding documentation PR

-

Types of change

Refactoring.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran all tests in tests and usage_examples/tests, and all new and existing tests passed. This includes
    • all external tests (i. e. pytest ran with --external)
    • all tests requiring a GPU (i. e. pytest ran with --gpu)
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@rmitsch rmitsch added refactoring Refactoring of existing code feat/task Feature: tasks labels Sep 20, 2023
@rmitsch rmitsch self-assigned this Sep 20, 2023
@rmitsch rmitsch changed the base branch from main to develop September 20, 2023 10:05
@rmitsch rmitsch added Test external Run external tests Test GPU Run GPU tests labels Sep 20, 2023
@rmitsch rmitsch force-pushed the refactor/ditch-kwargs branch from 9c831ce to 52e712a Compare September 21, 2023 08:09
@rmitsch rmitsch marked this pull request as ready for review September 21, 2023 08:17
svlandeg
svlandeg approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor!

@svlandeg svlandeg merged commit 3283d99 into develop Oct 11, 2023
11 checks passed
@svlandeg svlandeg deleted the refactor/ditch-kwargs branch October 11, 2023 07:59
@svlandeg svlandeg restored the refactor/ditch-kwargs branch October 11, 2023 07:59
@svlandeg svlandeg deleted the refactor/ditch-kwargs branch October 11, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg approved these changes

Assignees

@rmitsch rmitsch

Labels
feat/task Feature: tasks refactoring Refactoring of existing code Test external Run external tests Test GPU Run GPU tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmitsch @svlandeg