Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Neon ISA example #695

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Adds Neon ISA example #695

wants to merge 4 commits into from

Conversation

rtzam
Copy link
Contributor

@rtzam rtzam commented Aug 23, 2024

This CL adds the Neon equivalent
of the x86-AVX example. It changes
the Makefile to build the neon
example. It also modifies
the provided main.c file
to work for either the
generated neon or avx code

This CL adds the Neon equivalent
of the x86-AVX example. It changes
the Makefile to build the neon
example. It also modifies
the provided main.c file
to work for either the
generated neon or avx code
@rtzam rtzam requested a review from yamaguchi1024 August 23, 2024 20:57
@yamaguchi1024
Copy link
Member

We probably need to clean up the Python code and modify the readme to point to the Neon example. I think we should merge the documentation / tutorial changes at once.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.78%. Comparing base (37dc108) to head (672a2ac).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #695   +/-   ##
=======================================
  Coverage   87.78%   87.78%           
=======================================
  Files          84       84           
  Lines       20721    20721           
=======================================
  Hits        18190    18190           
  Misses       2531     2531           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gilbo
Copy link
Contributor

gilbo commented Sep 3, 2024

The README.md file is out of sync with the code. Let's discuss a path to getting this committed ASAP in person. I can share an optional code rewrite with some alternate comments as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants