Update the CF example contract

[elie222]

No description provided.

[elie222]

@royosherove @lawweiliang lmk if you have any thoughts. may still be some updates and cleanups here

[lawweiliang]

@elie222 , even after the token had revoked, user still can refund.
I think we need to add an additional checking over refund function

require(!hasRevokedRefund[tokenId], "Refund revoked for this token");

[lawweiliang]

Add constant keyword

[lawweiliang]

I think it would be better with just

contract CryptoFightersV2 is ERC721R{
}

---

Then, this part can be cut off as well

import "erc721r/contracts/ERC721R.sol";

Simple and clean code. 😄

[lawweiliang]

This error message is not meaning. Maybe we can put something like.
Insufficient ETH to mint the token. or Insufficient ETH value to mint the token

• Same apply to other functions

[lawweiliang]

For royalty ERC2981 part, I guess we need the resetTokenRoyalty as well.

Reasons

1. Cause if we made mistake, we are still able to change the royalty.
2. As the project getting more and more expensive, the royalty will increase as well, so we need to update the royalty.
   If worry about the community, before we update the royalty, we will propose and see the feedback.

[elie222]

The ERC2981 part should be standard. Don't think we did anything special there.

import "erc721r/contracts/ERC721R.sol";

we don't have this yet though. ERC721RExample has a lot of extras to it. it needs to be cleaned out a lot

even after the token had revoked, user still can refund.

yes, definitely looks like an issue. i'll check what the latest around this is and get an update to the pr

[davidberiro]

For royalty ERC2981 part, I guess we need the resetTokenRoyalty as well.

Reasons

1. Cause if we made mistake, we are still able to change the royalty.
2. As the project getting more and more expensive, the royalty will increase as well, so we need to update the royalty.
   If worry about the community, before we update the royalty, we will propose and see the feedback.

We could "set" the selected token id to the default amount, but then it won't track any future changes to the default royalty. I agree this should be added.