-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1528 ] Remove mentions and uses of unless
#1539
Conversation
Thank you for contributing to Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:
Automated comment created by PR Commenter 🤖. |
@@ -2,7 +2,7 @@ | |||
|
|||
## General | |||
|
|||
- Read about `if` in the official [Getting Started guide][getting-started-if-unless] or on [elixirschool.com][elixirschool-if-unless]. | |||
- Read about `if` in the official [Getting Started guide][getting-started-if] or on [elixirschool.com][elixirschool-if]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Elixir School links was broken
I'm fine with either merging it right now and then creating a new ticket to update the hash locations in the docs to the new ones without |
I think we can merge it, I can write an update on the ticket open and keep it open. |
Co-authored-by: Angelika Cathor <[email protected]>
Closes #1528
It's a bit unfortunate that some links (like
https://hexdocs.pm/elixir/case-cond-and-if.html#if-unless
) mention unless in the hash, but it'll be a quick fix. We could also wait for 1.18 before merging this.