Fix types in complex numbers (#1467)

* Fix types in complex numbers * abs also number
exercism · May 25, 2024 · 6855116 · 6855116
1 parent 2a3305b
commit 6855116
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 16 deletions.
diff --git a/exercises/practice/complex-numbers/.meta/example.ex b/exercises/practice/complex-numbers/.meta/example.ex
@@ -5,45 +5,45 @@ defmodule ComplexNumbers do
   For example, the real number `1` is `{1, 0}`, the imaginary number `i` is `{0, 1}` and
   the complex number `4+3i` is `{4, 3}'.
   """
-  @type complex :: {float, float}
+  @type complex :: {number, number}
 
   @doc """
   Return the real part of a complex number
   """
-  @spec real(a :: complex) :: float
+  @spec real(a :: complex) :: number
   def real({real, _im}), do: real
 
   @doc """
   Return the imaginary part of a complex number
   """
-  @spec imaginary(a :: complex) :: float
+  @spec imaginary(a :: complex) :: number
   def imaginary({_real, im}), do: im
 
   @doc """
   Multiply two complex numbers, or a real and a complex number
   """
-  @spec mul(a :: complex | float, b :: complex | float) :: complex
+  @spec mul(a :: complex | number, b :: complex | number) :: complex
   def mul({a, b}, {c, d}), do: {a * c - b * d, b * c + a * d}
   def mul(a, b), do: mul(to_complex(a), to_complex(b))
 
   @doc """
   Add two complex numbers, or a real and a complex number
   """
-  @spec add(a :: complex | float, b :: complex | float) :: complex
+  @spec add(a :: complex | number, b :: complex | number) :: complex
   def add({a, b}, {c, d}), do: {a + c, b + d}
   def add(a, b), do: add(to_complex(a), to_complex(b))
 
   @doc """
   Subtract two complex numbers, or a real and a complex number
   """
-  @spec sub(a :: complex | float, b :: complex | float) :: complex
+  @spec sub(a :: complex | number, b :: complex | number) :: complex
   def sub({a, b}, {c, d}), do: {a - c, b - d}
   def sub(a, b), do: sub(to_complex(a), to_complex(b))
 
   @doc """
   Divide two complex numbers, or a real and a complex number
   """
-  @spec div(a :: complex | float, b :: complex | float) :: complex
+  @spec div(a :: complex | number, b :: complex | number) :: complex
   def div({a, b}, {c, d}) do
     {(a * c + b * d) / (c * c + d * d), (b * c - a * d) / (c * c + d * d)}
   end
@@ -53,7 +53,7 @@ defmodule ComplexNumbers do
   @doc """
   Absolute value of a complex number
   """
-  @spec abs(a :: complex) :: float
+  @spec abs(a :: complex) :: number
   def abs({a, b}), do: :math.sqrt(a * a + b * b)
 
   @doc """

diff --git a/exercises/practice/complex-numbers/lib/complex_numbers.ex b/exercises/practice/complex-numbers/lib/complex_numbers.ex
@@ -5,54 +5,54 @@ defmodule ComplexNumbers do
   For example, the real number `1` is `{1, 0}`, the imaginary number `i` is `{0, 1}` and
   the complex number `4+3i` is `{4, 3}'.
   """
-  @type complex :: {float, float}
+  @type complex :: {number, number}
 
   @doc """
   Return the real part of a complex number
   """
-  @spec real(a :: complex) :: float
+  @spec real(a :: complex) :: number
   def real(a) do
   end
 
   @doc """
   Return the imaginary part of a complex number
   """
-  @spec imaginary(a :: complex) :: float
+  @spec imaginary(a :: complex) :: number
   def imaginary(a) do
   end
 
   @doc """
   Multiply two complex numbers, or a real and a complex number
   """
-  @spec mul(a :: complex | float, b :: complex | float) :: complex
+  @spec mul(a :: complex | number, b :: complex | number) :: complex
   def mul(a, b) do
   end
 
   @doc """
   Add two complex numbers, or a real and a complex number
   """
-  @spec add(a :: complex | float, b :: complex | float) :: complex
+  @spec add(a :: complex | number, b :: complex | number) :: complex
   def add(a, b) do
   end
 
   @doc """
   Subtract two complex numbers, or a real and a complex number
   """
-  @spec sub(a :: complex | float, b :: complex | float) :: complex
+  @spec sub(a :: complex | number, b :: complex | number) :: complex
   def sub(a, b) do
   end
 
   @doc """
   Divide two complex numbers, or a real and a complex number
   """
-  @spec div(a :: complex | float, b :: complex | float) :: complex
+  @spec div(a :: complex | number, b :: complex | number) :: complex
   def div(a, b) do
   end
 
   @doc """
   Absolute value of a complex number
   """
-  @spec abs(a :: complex) :: float
+  @spec abs(a :: complex) :: number
   def abs(a) do
   end