with: test / ;with in all test.8th

[axtens]

CLI-based testing issue reported in https://forum.exercism.org/t/having-trouble-with-8th/10069

Will take this up with Ron Aaron, that a with: test at the end of the ./libs/exercism/test doesn't appear to work when the file is needs included and that the with: test is required again in the test.8th file itself.

In hello-world, the with: test at the end of ./libs/exercise/test appears to be being ignored. Putting with: test after the needs in hello-world's test.8th makes the test namespace visible to the tests in test.8th

LATER
According to this conversation there's no point in putting with: test at the bottom of ./libs/exercism/test, so I've removed them.

[github-actions]

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

[glennj]

Right, that totally makes sense.

[axtens]

@ErikSchierboom so when the Test/ci fails because I don't have the token Run actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 Error: Input required and not supplied: token is it still okay to squash and merge given that the other items subsequent have a tick?

[glennj]

You have to be confident that the changes will pass the tests. I don't see anything dangerous here, and I assume you tested locally before creating the PR

[ErikSchierboom]

@ErikSchierboom so when the Test/ci fails because I don't have the token Run actions/checkout@b4ffde6 Error: Input required and not supplied: token is it still okay to squash and merge given that the other items subsequent have a tick?

It's a security/permissions thing. The only reason to workaround this is by creating the PR, not via the fork, but directly on this repo. In other words: to push the branch to this repo and not your fork, and then use that to create the PR from. This should work as you have repo permissions.

[ErikSchierboom]

Let's just merge and see

[ErikSchierboom]

It was almost correct, just acronym failing: https://github.com/exercism/8th/actions/runs/8156564580/job/22294372857

[glennj]

Fixed in #125