Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync docs and metadata #111

Merged
merged 2 commits into from
Jan 4, 2024
Merged

sync docs and metadata #111

merged 2 commits into from
Jan 4, 2024

Conversation

glennj
Copy link
Contributor

@glennj glennj commented Jan 2, 2024

No big changes, just syncing the docs and metadata with what's in problem specs.

@glennj glennj added the x:rep/tiny Tiny amount of reputation label Jan 2, 2024
@glennj
Copy link
Contributor Author

glennj commented Jan 2, 2024

@ErikSchierboom can you look into the CI failure?

Error: Input required and not supplied: token

This track checks out the 8th-test-runner:

token: ${{ secrets.TEST_RUNNER_PAT }}

@ErikSchierboom
Copy link
Member

@glennj #112 fixes this, so a rebase should fix the PR

@glennj
Copy link
Contributor Author

glennj commented Jan 3, 2024

@glennj #112 fixes this, so a rebase should fix the PR

Hmm, apparently not, even with the new SHA pin: https://github.com/exercism/8th/actions/runs/7397728111/job/20125384267?pr=111

image

@ErikSchierboom
Copy link
Member

@glennj Ah, now I know. This is running from your fork, which means it can't work :)

@ErikSchierboom ErikSchierboom merged commit 1176bfb into exercism:main Jan 4, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:rep/tiny Tiny amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants