Skip to content
This repository has been archived by the owner on Jun 11, 2019. It is now read-only.

Fix for issues with ini file on Ubuntu #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

loren-osborn
Copy link

This is a first pass work around. I'm new to Puppet and really don't know what I'm doing, so please give feedback about what I missed. This is really a case of "this [seems to] work for me".

-Thanks

@loren-osborn

This is a first pass work around. I'm new to
Puppet and really don't know what I'm doing, so
please give feedback about what I missed.

-Thanks
@alvagante
Copy link
Member

Well congratulations for the code, but to be honest it looks a bit too much: to manage particular cases it's enough to set a custom value for the config_file path, so I assume that can be enough for the not common cases.

@loren-osborn
Copy link
Author

I'm fine with manual configuration parameters, but the real problem I think I was having was that $php:: web_config_dir and $php:: config_dir weren't independent of each other, and weren't externally settable. Maybe drop the custom fact for a settable parameter, and go with the rest of the PR? (The custom fact turned out to only work AFTER php got installed after all, anyway.) Can you suggest a better strategy?

@alvagante
Copy link
Member

Ok, now I understand... and yes, I'd prefer an approach based on sane defaults which can be overridden by users.

@alvagante
Copy link
Member

Does this naive approach sound reasonable for you?
70a89b0
Surely less sophisticated than the solution you propose but definitively simpler, and possible less error proof and maintainable.

@loren-osborn
Copy link
Author

I'm still rather green on Puppet's syntax, and don't really have time to test this now, but it looks good in theory.

-Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants