Skip to content

Commit

Permalink
Add repro for metabase#13469 (metabase#13499)
Browse files Browse the repository at this point in the history
* Add repro for metabase#13469

* Simplify test

We don't need to test for numeric values, so the second check (loop) was unnecessary.
  • Loading branch information
nemanjaglumac authored Oct 16, 2020
1 parent fc4be09 commit 8591d67
Showing 1 changed file with 21 additions and 0 deletions.
21 changes: 21 additions & 0 deletions frontend/test/metabase/scenarios/question/new.cy.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -92,5 +92,26 @@ describe("scenarios > question > new", () => {
cy.get("[contentEditable=true]").contains(FORMULA);
});
});

it.skip("distinct inside custom expression should suggest non-numeric types (metabase#13469)", () => {
// go directly to custom question in "Reviews" table
cy.visit("/question/new?database=1&table=4&mode=notebook");
cy.findByText("Summarize").click();
popover()
.contains("Custom Expression")
.click();

cy.get("[contentEditable=true]")
.click()
.type("Distinct([R");

cy.log(
"**The point of failure for ANY non-numeric value reported in v0.36.4**",
);
// the default type for "Reviewer" is "No special type"
cy.findByText("Fields")
.parent()
.contains("Reviewer");
});
});
});

0 comments on commit 8591d67

Please sign in to comment.