Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ViewTreeLifecycleOwner to reliably get the lifecycle owner for databinding. #186

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use ViewTreeLifecycleOwner to reliably get the lifecycle owner for databinding. #186

wants to merge 1 commit into from

Conversation

evant
Copy link
Owner

@evant evant commented Apr 10, 2020

No description provided.

@evant evant force-pushed the viewtreelifecycleowner branch 2 times, most recently from 2d18305 to 1bb19c8 Compare April 10, 2020 02:17
@evant evant force-pushed the viewtreelifecycleowner branch from 1bb19c8 to a7a2050 Compare April 10, 2020 02:17
@evant evant changed the base branch from master to main June 14, 2020 22:18
@c-b-h
Copy link

c-b-h commented Sep 3, 2020

When is this commit being merged?

@evant
Copy link
Owner Author

evant commented Sep 7, 2020

Good question! The reason is it's been sitting here is I had hoped data binding would start using this method internally itself which would simplify the implementation. Haven't checked that that's the case or is on the roadmap.

@c-b-h
Copy link

c-b-h commented Sep 10, 2020

Could you consider merging, and in a later stage re-evaluate the need for it?

@c-b-h
Copy link

c-b-h commented Oct 14, 2020

Could you consider merging, and in a later stage re-evaluate the need for it? @evant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evant @c-b-h