verbose = !quiet
#284
Merged
verbose = !quiet
#284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R/render_docs.R
Outdated
| # Quarto sometimes raises errors encouraging users to set `quiet=FALSE` to get more information. | ||
| # This is a convenience check to match Quarto's `quiet` and `altdoc`'s `verbose` arguments. | ||
| dots <- list(...) | ||
| if ("quiet" %in% names(dots) && is.logical(dots[["quiet"]]) && length(dots[["quiet"]]) == 1) { |
There was a problem hiding this comment.
I think the length condition should be before the is.logical() to ensure we won't have an issue when is.logical() returns a vector of length > 1
There was a problem hiding this comment.
Good catch. But I think the proper fix is to have the length check in isTRUE(), because length() might not work at all or weirdly on objects of certain class.
|
I'll fix the test once the other PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Quarto breaks, it encourages users to call the same command with
quiet=FALSE. However, the analogous command inaltdoc::render_docs()is calledverbose. I keep getting caught by this, so thought I would implement a simple check to assignverbose <- !quietwhen the user usesquietin...This is hard to test, and I don't think we should advertise this feature. But it's a trivial change, so easy to review.