-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
render_docs(autolink = TRUE)
uses downlit
#273
render_docs(autolink = TRUE)
uses downlit
#273
Conversation
@etiennebacher I think this is ready for review now. In the end, I decided to set
|
In case you want to see it "live", I updated one of my websites: https://marginaleffects.com/vignettes/predictions.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah that looks great, nice one! Too bad it doesn't work with mkdocs
but the example with marginaleffects
looks really good.
I have some comments about some code refactor but I'm fine with the functionality. I think it's good to keep it opt-in for now if it messes up the formatting for docsify
and docute
Co-authored-by: Etienne Bacher <[email protected]>
Co-authored-by: Etienne Bacher <[email protected]>
Co-authored-by: Etienne Bacher <[email protected]>
a103c85
to
dba718b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, feel free to merge if you're done
This PR adds an
autolink
argument torender_docs()
to process vignettes, man pages, and home page usingdownlit
. This will auto-link function calls to web-based documentation.Links to external functions work without further intervention. Links to an
altdoc
website requires users to add apkgdown.yml
file in the root of the website like this:Users should probably host this file in
altdoc
Warning:
downlit
will only recognize internal links ifpkgdown.yml
is already hosted live on the website. This means that this won't work the first time the website is generated, and that local updates will not be reflected in links.TODO:
altdoc/pkgdown.yml
automatically withsetup_docs()
pkgdown.yml
hosted on a live website.